ci: pin cross and rust versions

deislabs / containerd-wasm-shims

containerd shims for running WebAssembly workloads in Kubernetes

Apache License 2.0

311 stars 48 forks source link

ci: pin cross and rust versions #200

Closed Mossaka closed 9 months ago

Mossaka commented 9 months ago

This pull request includes updates to the Rust toolchain and the Makefile to ensure specific versions are used and to include new components and targets. The most important changes include updating the rust-toolchain.toml file to use Rust version 1.75.0 and updating the install-cross target in the Makefile to specify a specific commit when installing cross.

Mossaka commented 9 months ago

Confirmed that an older cross image ghcr.io/cross-rs/x86_64-unknown-linux-musl:main@sha256:a8a5f982bca1a7c91227bb342749282a2eebc93daef16ce0 works. The newer image introduces the PIE build issue.

Mossaka commented 9 months ago

It looks like the enable-default-pie flag was removed in this PR.

Mossaka commented 9 months ago

https://github.com/cross-rs/cross/pull/1418 this PR adds PIE back.

Mossaka commented 9 months ago

Nice work locking in the version to avoid the PIE compilation issue.

Thanks! Just to clarify, locking in the version did not fix the PIE compilation issue. The fix was on upstream cross repo to enable PIE compilation in musl library.