search

deislabs / mystikos

Tools and runtime for launching unmodified container images in Trusted Execution Environments
142 stars 49 forks source link

Fix issue 1467 #1493

Closed isil-oz closed 11 months ago

isil-oz commented 1 year ago

@microsoft-github-policy-service agree

vtikoo commented 12 months ago

We don't have --perf documented in the usage strings, please document the existing functionality and the new additions you've made. The usage strings are here - Linux target - https://github.com/deislabs/mystikos/blob/main/tools/myst/host/exec_linux.c#L126 SGX target - https://github.com/deislabs/mystikos/blob/main/tools/myst/host/exec.c#L461

For existing --perf functionality you can add - reports time taken to boot and on shutdown reports time spent on each syscall.

isil-oz commented 11 months ago

We don't have --perf documented in the usage strings, please document the existing functionality and the new additions you've made. The usage strings are here - Linux target - https://github.com/deislabs/mystikos/blob/main/tools/myst/host/exec_linux.c#L126 SGX target - https://github.com/deislabs/mystikos/blob/main/tools/myst/host/exec.c#L461

For existing --perf functionality you can add - reports time taken to boot and on shutdown reports time spent on each syscall.

Done.

isil-oz commented 11 months ago

PR looks good! @mikbras had a suggestion about "peak_usage" being more clear than "max_usage"(and I agree).

Updated "max" with "peak".