Revert PR 97 and add some inline docs

deislabs / wagi

Write HTTP handlers in WebAssembly with a minimal amount of work

Apache License 2.0

889 stars 45 forks source link

Revert PR 97 and add some inline docs #103

Closed technosophos closed 3 years ago

technosophos commented 3 years ago

PR #97 cleaned up a bug in the file cache. But I am not sure exactly what bug. However, when the path changed, it was mistakenly mounting the entire cache directory instead of just the parcel's cache.

So all I did was revert the patch with a note about how it is designed to work. I might be re-introducing whatever bug @simongdavies was fixing, but I am not entirely sure what bug that was. We might need one more followup PR.

Signed-off-by: Matt Butcher matt.butcher@microsoft.com

radu-matei commented 3 years ago

@itowlson do you want to give this a try before merging?

itowlson commented 3 years ago

technosophos commented 3 years ago

BUTCHER MANUALLY TESTED IT ALREADY.