search

deitch / activator

Easy user activation and password reset, with email confirmation, for nodejs
85 stars 42 forks source link

authentication vs authorization #54

Closed miqmago closed 7 years ago

miqmago commented 7 years ago

Don't know which one is wrong:

https://github.com/deitch/activator/blob/master/README.md#templates-format Line 533 authorization

https://github.com/deitch/activator/blob/master/lib/activator.js#L69 authentication

deitch commented 7 years ago

Well, if that isn't a sloppy mistake! Nice catch.

Clearly, it should be authentication, since the code authenticates who you are, it does not authorize you to do anything. In any case, wouldn't want to break anything working without good reason.

Fixing now, closing in favour of immediate PR. Thanks for finding.

miqmago commented 7 years ago

I've seen that anyway code can be used in any case (they are the same value...)

So I understand that this will be fixed in README.md not in code (as you said, it could break projects using as it is now...)

deitch commented 7 years ago

Yep. Just merged and npm published. Thanks again.