search

deitch / aws-asg-roller

Manage rolling upgrades for AWS autoscaling groups
Apache License 2.0
57 stars 17 forks source link

fix: skip updating asgs with no outdated instances #12

Closed zaquestion closed 5 years ago

deitch commented 5 years ago

This is a good fix, but tests fail. We need either to fix the logic, or fix the tests if in error.

zaquestion commented 5 years ago

Updated the tests to provide a more accurate look at the state of variables when the roller is running. Its hard to reason about what all those maps will be from the perspective of the adjust func. Longer term I'd like to refactor adjust to require less state to manage the new/original desired settings. In the meantime hopefully these tests will suffice.

deitch commented 5 years ago

Hats off, this is a nice job.

Please just rebase and we can merge in.

Yeah, I know, travis is broken....

zaquestion commented 5 years ago

In case the rebase doesn't trigger a notification heres a comment letting you know I pushed it :D

deitch commented 5 years ago

Ha! No, GitHub doesn't trigger that. Although when I switch to GH actions (if I get past the issues), it should.