deitch / aws-asg-roller

Manage rolling upgrades for AWS autoscaling groups
Apache License 2.0
57 stars 17 forks source link

Support for Launch Templates #17

Closed tom-butler closed 5 years ago

tom-butler commented 5 years ago

This looks like a great tool!

Only issue is I'm using Launch Templates for my ASGs, instead of Launch Configuration. Is this something can be added to this tool?

deitch commented 5 years ago

I would like to see that. Launch Templates slowly (or not so slowly?) are replacing Launch Configs, so it makes sense. Let's see what we can do.

deitch commented 5 years ago

Fortunately, this turns out to be pretty simple. The entire LaunchConfiguration logic is encapsulated here, where it groups it by "old instances" (those that should be terminated and replaced) and "new instances" (those that have the new config). The rest of this doesn't really care why it is grouped just leverages it.

The slightly difficult part will be behaviour when both config and template are set, but we can handle that.