deitch / aws-asg-roller

Manage rolling upgrades for AWS autoscaling groups
Apache License 2.0
57 stars 17 forks source link

Support mixed instance policies. #33

Closed deverton closed 4 years ago

deverton commented 4 years ago

When a mixed instance policy is enabled for an autoscaling group, the launch template value is under the mixed instances policy part of the returned object.

TwiN commented 4 years ago

Nice catch!

colinliddlemyob commented 4 years ago

Ahah, I just encountered this issue as well, did a build off the branch and it works for me

deitch commented 4 years ago

Really nice catch, and a nice little gofmt update for icing on the cake.

deitch commented 4 years ago

Can you please rebase and then we can merge in right away?

Hoping everyone is healthy.

deverton commented 4 years ago

I've merged in master so it should be up to date. Do you want an actual rebase and force push?

deitch commented 4 years ago

All good, thanks.

deverton commented 4 years ago

Excellent! Thanks for merging.

deitch commented 4 years ago

Thanks for the PR! :-)

Have a good and healthy weekend.