search

deitch / aws-asg-roller

Manage rolling upgrades for AWS autoscaling groups
Apache License 2.0
57 stars 17 forks source link

Adds verbose logging for MixedInstancesPolicy #35

Closed pcornish closed 4 years ago

pcornish commented 4 years ago

This adds verbose logging when using Mixed Instances Policy.

Logs

The additional (verbose only) log entry looks like this:

2020/03/27 11:16:52 [my_asg_name] using mixed instances policy launch template

Note: This PR originally added support as well as the verbose logging. The support itself was merged a few hours ago, so this just adds the logging!

Original PR follows

This adds support for Auto Scaling Groups using a Mixed Instances Policy.

In this case, where more than one instance type is permitted for the ASG, the launch template is nil and the roller fails with:

both target launch configuration and launch template are nil

Please see https://docs.aws.amazon.com/autoscaling/ec2/APIReference/API_MixedInstancesPolicy.html for background information.

Logs

The additional (verbose only) log entry looks like this:

2020/03/27 11:16:52 [my_asg_name] using mixed instances policy launch template
deitch commented 4 years ago

Also, tests are failing.