deitch / cansecurity

nodejs/expressjs authentication and security library
MIT License
150 stars 53 forks source link

Cansecurity seems to rely on async but doesn't include it #4

Closed socketwiz closed 11 years ago

socketwiz commented 11 years ago
module.js:340
    throw err;
          ^
Error: Cannot find module 'async'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/Users/rickyn/tmp/cans/node_modules/cansecurity/lib/declarative.js:2:76)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)

Steps to reproduce:

  1. npm install cansecurity
  2. Create a file (can.js) with a single line: var cs = require('cansecurity');
  3. node can.js
deitch commented 11 years ago

OK, so I know I use async a lot, so I never end up with a situation without it, and it is in the devDependencies. But that is one seriously sloppy mistake. Doh!

Thanks for pointing it out, cutting a new version right now...

deitch commented 11 years ago

See v0.6.9 commit https://github.com/deitch/cansecurity/commit/47b36597e949e014f3f7fee044f4f824e6674561