This implementation works but has a few potential issues that may or may not be a problem for the maintainers:
There's a typescript error because the <Code> component expects children, but we can't provide both children and dangerouslySetHtml
There may be a better way to exclude children from props before passing them to <Code>.
There may be a better way to convert children to a string before passing to hljs.
The background color for code blocks seems to come from the markdown display library rather than hljs. With the github.css theme currently used this looks fine, but other hljs themes can look pretty bad as they expect a black background.
for #35
This implementation works but has a few potential issues that may or may not be a problem for the maintainers:
<Code>
component expects children, but we can't provide both children and dangerouslySetHtml<Code>
.github.css
theme currently used this looks fine, but other hljs themes can look pretty bad as they expect a black background.