search

deiv / driftnet

Driftnet watches network traffic, and picks out and displays JPEG and GIF images for display
GNU General Public License v2.0
433 stars 54 forks source link

fix clang compilation: strip inline keyword #1

Closed FauxFaux closed 10 years ago

FauxFaux commented 10 years ago

The inline keyword actually changes the semantics in c99, instead of just acting as a hint. The usage in driftnet is incorrect.

http://clang.llvm.org/compatibility.html#inline explains why clang does different things.

Testcase:

./configure CC=clang CXX=clang++ && make
deiv commented 10 years ago

I always think that inline were only a mere hint, but I was complete unaware of the C99 behavior that threats it like a declaration. Good to know.

Thanks for the pull Chris !!