Closed mscheltienne closed 3 months ago
Also, if you want the follow-up PRs, I would not release until I add those (would be very quick).
And in any case, if you release with a new directory name (thus a new import), I would release a new major version, 2.0.0
to indicate the backward incompatibility.
@mscheltienne Thanks again. any follow-up PRs will be nice if needed. I will play around with this over the weekend. I also some that you updated this to use toml! Thanks for that
Close #11
@deivit24 Seeing your positive feedback for the requested (backward incompatible) change, I took the time to open this PR with the proposed change. Feel free to commit on top of it; or to open a separate PR and close this one; if you prefer to fix the issue differently.
In this PR:
python-steam-api
is maintained.pip install python-steam-api
will still be the correct installation.steam
tosteam_web_api
, preventing naming conflicts with the larger https://github.com/ValvePython/steam The package can now be imported with:setup.py
to the current standard,pyproject.toml
MANIFEST.in
,requirements.txt
are removedsteam_web_api.__version__
As a new user of this package, I would also like to make sure it adheres to the current coding standards to ensure it has a long and prosperous life. If you want, I can open a succession of short PR to:
flake8
, nowadays,ruff
is the preferred linter and formatter. Personaly, I would addruff
,isort
,codespell
pre-commit
configuration andpre-commit.ci
for automatic style checksHopefully, the changes here will also be beneficial to other project you work on!