search

dejw / vip

vip is a simple library that makes your Python aware of existing virtualenv underneath.
3 stars 1 forks source link

Various additional tests & fixes #7

Closed juntalis closed 11 years ago

juntalis commented 12 years ago

Hey,

Threw together the additional fix I mentioned, and the additional tests. I had to actually separate the two command execution tests, due to the fact that Windows uses a "Scripts" folder, and everything else uses a "bin" folder.

juntalis commented 12 years ago

Damn it, just got a failed test on this. Let me figure out what's going on and I'll update this.

Hey, going to actually close this one until I apply some changes. I've always used tabs in my code, so when I started using Python, I couldn't really bring myself to use 4 spaces, and as a result, I don't use pep8 to check my code style. Since this project uses pep8, though, I'll go ahead and go back through and fix any issues travis is reporting right now.

dejw commented 12 years ago

You do not have to close issue, you could just push new commits into your branch, and they will be automatically picked up by pull-request (that is how it work with normal branches so it should work the same with pull requests).

juntalis commented 12 years ago

Ah, didn't realize that. Had always assumed that pull requests were on a per-changeset basis, to allow multiple pull requests from forked repositories in the case where multiple issues were being addressed. Reopening this one, in that case.

juntalis commented 12 years ago

Yeah, I'm pretty awful when it comes to writing tests for my personal stuff, and since I don't get much of an excuse to use python at work, I don't know the Python frameworks all that well.

I think I might actually start using Travis for some other my other projects, though, based on this.

dejw commented 12 years ago

Travis is pretty cool. Apparently, it was integrated into Github very deeply, since I can see tests status about this pull request.

juntalis commented 12 years ago

Yeah, that was the bit that I thought was actually pretty cool.

Hey, I'd rather not pollute your change log with so many one useless commits consisting of one-character changes for the purpose of styling, and redundant code that got erased only a few commits later. I'm going to go ahead and open a new branch to spread the actual changes across a handful of commits, but do you happen to know if there's a way to reassign a different branch to a pull request, or would I need to close out this one and start a new one?

dejw commented 12 years ago

First of all, I don't mind any changes in my code. Feel free to change any piece of my code. Nevertheless, I agree that the behavior you described is really strange.

Also I don't mind pulling small commits ;-) You can finish this pull request now, but from now on, you can create a branch and make a pull request out of it.

Don't know if there is a way oh changing the source of the pull request. At least you can later push commits from new branch into this pull request to pick them up. Or you can use git rebase --interactive to squash commits into one an push them here. Either way is fine.

juntalis commented 12 years ago

Hey, sorry about that. Got slammed with three projects at work, and ended up having to focus solely on that for a while. Anyways, I kind of lost track - did we have any more unresolved issues with this change? If not, I think that's all I have in terms of compatibility fixes for the time being, though I'm sure as I start working on personal projects again, an idea or two will come to mind.

dejw commented 11 years ago

I am sorry for a late response. Got this week tons of other things to do. Merged.

I think for now everything works on both Linux and Windows.