Update for Swift 4.2 support

dekatotoro / SlideMenuControllerSwift

iOS Slide Menu View based on Google+, iQON, Feedly, Ameba iOS app. It is written in pure swift.

MIT License

3.4k stars 754 forks source link

Update for Swift 4.2 support #418

Open Nomad00 opened 5 years ago

Nomad00 commented 5 years ago

Remove unneeded entry of Info.plist from the Copy Bundle Resources build phase.
Apply Xcode suggested project settings updates.
Convert SlideMenuControllerSwift scheme to Swift 4.2.
Convert SlideMenuControllerSwift-iOS scheme to Swift 4.2.
Update podspec to increase version number to 4.2.0.
Add swift_version to podspec (4.2).
Update CHANGELOG.md to indicate Swift 4.2 change.

Closes dekatotoro/SlideMenuControllerSwift#399, dekatotoro/SlideMenuControllerSwift#398, dekatotoro/SlideMenuControllerSwift#383 & dekatotoro/SlideMenuControllerSwift#378

AndyDunn commented 5 years ago

Are these changes still pending merging to the master branch?

juanm4 commented 5 years ago

Hi, how can I add this commit to mi podfile? I'm trying with this:

pod 'SlideMenuControllerSwift', :git => 'https://github.com/dekatotoro/SlideMenuControllerSwift.git', :commit => 'ae0d5588a99bc92e16a92d5dd594bad89963c363'

but this doesn't work, the result with pod update is:

fatal: reference is not a tree: ae0d5588a99bc92e16a92d5dd594bad89963c363

Thanks in advance.

Nomad00 commented 5 years ago

👋 @juanm4, Until this is merged in, you would need to refer to my fork. For example, I have: pod 'SlideMenuControllerSwift', :git => 'https://github.com/Nomad00/SlideMenuControllerSwift.git', :branch => 'swift4.2' in my podfile.

Suresh-Alangat commented 4 years ago

Shows the following warning

'fabs' is deprecated: renamed to 'abs'