search

dekimasoon / vue-cli-plugin-cordova

This repository is deprecated. Please check https://github.com/m0dch3n/vue-cli-plugin-cordova
MIT License
38 stars 14 forks source link

Please update to Vue CLI 3.0.x and remove vuetify dependency #26

Closed eladcandroid closed 5 years ago

eladcandroid commented 6 years ago

Vuetify shouldn't be the default dependency (maybe can be switched from options on install)

am commented 6 years ago

I do agree on this, looks like an optional dependency. As matter of fact I see that this 3 relate:

Though updating vue-cli and drop optional dependencies are different issues.

m0dch3n commented 6 years ago

Hi, just jfyi, I created another cordova plugin, free of any unnecessary dependencies

https://github.com/m0dch3n/vue-cli-plugin-cordova

dekimasoon commented 6 years ago

Vuetify shouldn't be the default dependency

You are right. I should do this. Hope I could do something in this weekend. As an excuse, my first baby was born three months ago...

Should try the @m0dch3n plugin! @m0dch3n It's awesome! I really impressed your approach.

eladcandroid commented 6 years ago

@m0dch3n I'll try it. Thanks!!

m0dch3n commented 6 years ago

Thanks @dekimasoon & @eladcandroid

My approach was inspired by your plugin and the cli of quasar framework. So in fact nothing new, but in my opinion, the best parts of both approaches, meaning, no dependency to vuetify etc, and no dependency to stay in the quasar framework environment. I prefer vue 3 cli, and quasar being only an addon.

eladcandroid commented 6 years ago

@m0dch3n Great! That's exactly my approach. We should tell Quasar to add a reference in their docs to use Cordova support with Vue CLI 3

m0dch3n commented 6 years ago

@eladcandroid for quasar there are still some more things todo, i.e $q.platform.is.mobile etc... I'm currently investigating into this, and I'll create a second plugin for that... But currently I don't have time for that,as I'm in holiday the next 2 weeks... You can check my repos afterwards, to see, if something has been done...

eladcandroid commented 6 years ago

@m0dch3n You can add quasar plugin next to your plugin.. "vue add quasar" and then you can just use $q like in the Default.vue file there...

m0dch3n commented 6 years ago

@eladcandroid I know, but as I said, there are more things still todo, like $q.platform.is.cordova needs to return true on a cordova build, so that the backbutton i.e. is handled by quasars component automatically...

https://github.com/quasarframework/quasar/blob/472983e7d1419f17dc1986ada9076275ce393c11/src/history.js

But let's discuss these problems, once I created the quasar cordova specific vue plugin...

dekimasoon commented 5 years ago

close now.