dekimir / postgres-searchbox

Enables react-instantsearch to work directly on PostgreSQL tables
Other
14 stars 1 forks source link

Feature/facets #12

Closed data-envoy closed 1 year ago

data-envoy commented 1 year ago

This PR implements facets and filtering on data within a single table.

In client.ts I renamed... queries: Query[] -> requests: Request[] . To try and avoid ambiguity, because there is a query property. But, I think requests is a poor choice, as it's ambigous with http requests.

BTW. This includes the highlight PR, in case you want to ignore that.

Fixes https://github.com/dekimir/postgres-searchbox/issues/13

dekimir commented 1 year ago

Thank you. Let's work on the highlight PR first, to get that merged soon.

dekimir commented 1 year ago

9 has now landed in main, so please rebase on that, for easier reviewing.

data-envoy commented 1 year ago

Great, I'll reply to the review later :). This has been rebased.

data-envoy commented 1 year ago

Adding to the list here

data-envoy commented 1 year ago

The snapshots changed because the when I added a new faker call likefaker.company.name() to createRandomProduct. It knocked all of the subsequent faker calls out of sync.

I think the seed number increases by one on every faker.x() call. I will try and address this, but the snapshots will change one more final time.

data-envoy commented 1 year ago

@dekimir thanks for the review. I think everything has been addressed here.