Closed data-envoy closed 1 year ago
Thank you. Let's work on the highlight PR first, to get that merged soon.
main
, so please rebase on that, for easier reviewing.Great, I'll reply to the review later :). This has been rebased.
Adding to the list here
The snapshots changed because the when I added a new faker call likefaker.company.name()
to createRandomProduct
. It knocked all of the subsequent faker calls out of sync.
I think the seed number increases by one on every faker.x() call. I will try and address this, but the snapshots will change one more final time.
@dekimir thanks for the review. I think everything has been addressed here.
This PR implements facets and filtering on data within a single table.
In client.ts I renamed... queries: Query[] -> requests: Request[] . To try and avoid ambiguity, because there is a
query
property. But, I thinkrequests
is a poor choice, as it's ambigous with http requests.BTW. This includes the highlight PR, in case you want to ignore that.
Fixes https://github.com/dekimir/postgres-searchbox/issues/13