search

dekinet / MMM-Growatt

Magic Mirror module for displaying Growatt inverter data
MIT License
2 stars 1 forks source link

Added a visualization - however the code is a mess :D #3

Open lenikey opened 1 year ago

lenikey commented 1 year ago

Hey @dekinet I played around with the module a bit and added a nice little visualization of the power distribution: image

It also supports the arrows changing direction depending on charging / discharging as well as importing / exporting power from / to the grid. I would be very happy to create a pull request for you to review, however my coding skills are very limited leading to a very ugly and unnecessary long code. It would need to be refactored, however I am not able to do it myself.

Let me know if you are interested given these circumstances and I will be happy to upload my files.

dekinet commented 1 year ago

Hi @lenikey, thanks again for offering to contribute to this project. While I appreciate the offer, I think your contribution might be better directed at an existing visualisation like EnergyMonitor. Perhaps you have some ideas to improve/extend that project? I feel that would be better than adding a visualisation into this module.

In order to support EnergyMonitor, this Growatt project would need to be modified to send notifications in the format required by EnergyMonitor. I'd be happy for you to do that in this (Growatt) module. I've been thinking about doing it for a while, so am also happy to do that myself if it would help you out.

Let me know what you think.

andersfalt commented 1 year ago

I would be happy to take a look at the module and try it out.

lenikey commented 1 year ago

Hey @andersfalt. Sorry for letting you wait. I created this pull request to give you the chance to review: https://github.com/dekinet/MMM-Growatt/pull/4

dekinet commented 2 months ago

Hi @andersfalt and @lenikey : Not sure where this is at? Can this issue be closed?