Closed Qashworth closed 10 months ago
Thanks @lunakv, I'll be sure to format future PR's accordingly!
I did just notice that I failed to add the Form
component to the other imported components for FilterCollapse.js
in this PR, which breaks List view entirely:
What would be the best way to go about including that component? Reverting this PR, opening a new one, some other third thing?
Description
This PR wraps the button in a form to handle
Enter
/ 'Return' keypress events within the .component instead of requiring users specifically click the 'Apply' Button discussed in #2421Background
Currently users need to explicitly press the 'Apply' button to submit filtered searches. This is an attempt to handle
Enter
/Return
Key presses within theFiltercollapse.js
component instead of requiring users specifically click the 'Apply' Button. I've wrapped theInputGroup
in aForm
, removed the 'Apply' button'sonClick
event, added the"submit" type
to the 'Apply' button, and added a function to handle when theonSubmit
event is fired.This should allow the 'Apply' button to maintain it's ability to be clicked as well as fire when the
Enter
/Return
Key is pressed.How to test
Enter
/Return
key on your keyboardAdditional Notes:
My first PR here (of hopefully many more) please be gentle! 😂