dekkerglen / CubeCobra

An open source web application for building, managing, and playtesting Magic the Gathering cubes.
https://www.cubecobra.com
Apache License 2.0
194 stars 121 forks source link

NaN mana value causes card to be hidden. #2474

Open nulldrifter opened 4 weeks ago

nulldrifter commented 4 weeks ago

Describe the bug When the mana value of a card is set to NaN, (e.g. a semicolon), the API allows this invalid data to be changed. Upon fetching the card again, it is no longer displayed in the Cube List. It is present in the API response and accounted for in the list total (e.g. Lands (23)) but it is not present in the list. The lack of visibility makes it impossible to revert the unintended change.

To Reproduce Steps to reproduce the behavior:

  1. Go to a cube list
  2. Edit Card
  3. Set Mana value to ;

Expected behavior An error and/or for the value to revert from the invalid input to the previous value.

Additional context Example cube id: 0abfad63-7751-449f-9cdb-2ac582804495

nulldrifter commented 4 weeks ago

There appears to be a delayed reconciliation for this issue. The affected card is no longer visible after ~20 minutes. Closing issue.