search

dekkerglen / CubeCobra

An open source web application for building, managing, and playtesting Magic the Gathering cubes.
https://www.cubecobra.com
Apache License 2.0
186 stars 115 forks source link

Use Oracle ID instead of Name to find card versions. #970

Open ruler501 opened 4 years ago

ruler501 commented 4 years ago

What would you like to be able to do? I would like cards that share names, such as the Very Cryptic Commands, to show up as distinct cards in cube comparisons, adding and deleting, pricing and card ratings.

Describe how you would use the feature It would allow bots to draft smarter for Unstable cards, more accurate buy price information for cubes, and better comparisons between cubes.

Additional context Will have to change code in a number of places to lookup printings by oracle ID since we use name everywhere currently. Will also need to add a script to migrate ratings data to use oracle ID, likely make duplicates of the existing data for each oracle ID that corresponds to that name.

dekkerglen commented 4 years ago

Not all card objects have oracle IDs, unfortunately

phulin commented 4 years ago

@dekkerglen can you give some more detail? which ones are missing them? older cards etc.?

dekkerglen commented 4 years ago

I don't know exactly, but definitely all the 'extras', all of which you can add to your cube

devonrichardsz commented 4 years ago

Maybe we could create an "oracle ID" for them based off whatever is unique about them?