search

dekkerlab / cLIMS-docker

cLIMS repository running on Docker Contaienrs
GNU Lesser General Public License v3.0
3 stars 4 forks source link

1.Restricting EDIT/DELETE options 2.resolving the error for changes made in JASON fields #79

Closed Snehal1894 closed 4 years ago

Snehal1894 commented 4 years ago

1) This will prevent uses from changing objects that are shared by everyone. 2) There are fields in forms that show different fields based on selection type. When such fields are changed, their associated JSON fields also change, so comparing the old and updated fields was giving error (like key not found).

sergpolly commented 4 years ago

@Snehal1894 - looks nice ! although I wonder if there is a better way to just commenting the buttons ... you're commenting them for all the users, right, including admins ? SO in order to actually remove something admins would need to go to the admin panel to curate database directly, right ? maybe we could leave a message on the page somewhere - instead of those buttons - something like - "in order to edit/delete your records please contact your admin" ...

or even maybe leave the buttons edit/delete, but when pressed instead of editing/deleting - they'll show a meesage: "in order to edit/delete your records please contact your admin" - i.e. we'd leave the functionality there (maybe for the future) - what do you think about that ?

Snehal1894 commented 4 years ago

@Snehal1894 - looks nice ! although I wonder if there is a better way to just commenting the buttons ... you're commenting them for all the users, right, including admins ? SO in order to actually remove something admins would need to go to the admin panel to curate database directly, right ? maybe we could leave a message on the page somewhere - instead of those buttons - something like - "in order to edit/delete your records please contact your admin" ...

or even maybe leave the buttons edit/delete, but when pressed instead of editing/deleting - they'll show a meesage: "in order to edit/delete your records please contact your admin" - i.e. we'd leave the functionality there (maybe for the future) - what do you think about that ?

Even if you do that, admins would still be needing to go the admin panel to make any changes.

sergpolly commented 4 years ago

yes this is true, but with the last scenario:

or even maybe leave the buttons edit/delete, but when pressed instead of editing/deleting - they'll show a meesage: "in order to edit/delete your records please contact your admin" - i.e. we'd leave the functionality there (maybe for the future) - what do you think about that ?

the html wouldn't change so it's a bit nicer for the users maybe - they used to see those buttons there... That would require more work perhaps

sergpolly commented 4 years ago

for the lack of time - we need to use thios as is - to prevent users from "damaging" the database - we need to think of what to do next with it