search

dekorateio / dekorate

Tools for generating Kubernetes related manifests.
Apache License 2.0
477 stars 103 forks source link

chore: centralize handling of container decorator order #1193

Closed iocanel closed 1 year ago

iocanel commented 1 year ago

The pull request move containers dekorator order handling (before / after) methods to the ApplicationContainerDecorator class. Also, adds ApplicatonContainerDecorators to run after AddInitContainerDecorator.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

iocanel commented 1 year ago

@Sgitario: AddInitContainerDecorator was not ordered correctly. With this change all of our existing decorators that modify containers (extending ApplicationContainerDecorator) should run after AddInitContainerDecorator.

So, theoretically we should be able to change image, command, args, env etc (for init containers) without introducing new decorators.