search

dekorateio / dekorate

Tools for generating Kubernetes related manifests.
Apache License 2.0
471 stars 101 forks source link

[2.11] Revert "fix: route port" #1206

Closed Sgitario closed 1 year ago

Sgitario commented 1 year ago

This reverts commit 21ef3c382db86394fed765eabb3b30eb8609baf1.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sgitario commented 1 year ago

We were wrong about reverting this change. From OpenShift docs: targetPort is the target port on pods that is selected by the service that this route points to.

So, we should keep using the container port, not the host-port.

Sgitario commented 1 year ago

By the way, this was spotted by one test we have in our CI :)