fix: integration with Tekton - Githubissues

dekorateio / dekorate

Tools for generating Kubernetes related manifests.

Apache License 2.0

477 stars 103 forks source link

fix: integration with Tekton #1216

Closed Sgitario closed 1 year ago

Sgitario commented 1 year ago

The integration with Tekton was broken for the following reasons:

The service account integration was totally broken: so, neither private container registry could be used, nor the k8s manifests could be installed
The kaniko image used to build and push the images was not working (one missing parameter and a wrong parameter related to the context)
The extension was not supporting a multi-module project
The image-pull-secret property was not taking into account: I had to revert https://github.com/dekorateio/dekorate/commit/1bcf751b08fca189fcb2f86d75a946da7dc09831
Updated documentation and CI

All above have been fixed and addressed.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

Sgitario commented 1 year ago

LGTM For future reference, I would prefer individaul pull requests per problem fixed, as this make it a bit hard to review.

To ease the review, there are separate commits within this pull request. Pull request should address or handle one issue, and I did it when it made sense (see https://github.com/dekorateio/dekorate/pull/1214, https://github.com/dekorateio/dekorate/pull/1213, https://github.com/dekorateio/dekorate/pull/1212, https://github.com/dekorateio/dekorate/pull/1211).