search

dekorateio / dekorate

Tools for generating Kubernetes related manifests.
Apache License 2.0
471 stars 101 forks source link

Tekton: Migrate from PipelineResources #1218

Closed Sgitario closed 1 year ago

Sgitario commented 1 year ago

@Sgitario I tried reviewing the PR but I am missing the context. It's not clear to me what you are trying to do and why.

Some rough examples:

  • Why do we need a clone step ?

We need a git clone step, because the PipelineResources of type git is removed in Tekton 0.47. For the migration, I did what was described in https://tekton.dev/docs/pipelines/resources/ which says to replace the pipelineresources to params and use the git-clone task (see the image).

  • Why in some areas are replacing ouput references for had coded values ?

As far as I see, there are no hard-coded values, but default values that users can modify if needed. I don't think this has changed by these changes. But before these properties were provided via resources inputs/outputs, and now via params.

Note, that I have't touched tekton for nearly two years now, so I am bit rusty.

iocanel commented 1 year ago

Thanks @Sgitario much clearer now.

Sgitario commented 1 year ago

Thanks @Sgitario much clearer now.

No problem!

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sgitario commented 1 year ago

@iocanel PR updated with the changes you proposed.