search

dekorateio / dekorate

Tools for generating Kubernetes related manifests.
Apache License 2.0
479 stars 104 forks source link

Rename component group of the component #200

Open cmoulliard opened 5 years ago

cmoulliard commented 5 years ago

Rename component group of the component

As we can't use the name k8s.io to create non official kubernetes operators and custom resource definition, then we must change the group name component.k8s.io of the component operator to appdev.snowdrop.me

cmoulliard commented 5 years ago

FYI. We will perhaps use a different domain name and not snowdrop.me|dev for the component operator

metacosm commented 5 years ago

We should probably make the component group a property that could be set at runtime instead of hardcoding it since the group name will probably be in flux for a while…

cmoulliard commented 5 years ago

Can we do that @iocanel ?

cmoulliard commented 5 years ago

@iocanel Can you reply please ?

iocanel commented 5 years ago

@cmoulliard: Sorry, this sliped my attention.

Yes, we can do it and the correct label should be dekorate.io/group or something like that.

We should also change the rest of the labels we use, so that the align with the recommended kubernetes labels: https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels

This is probably a breaking change so we either need to bump the major version, or use both the old and new for a period of time to give people time to adapt.

cmoulliard commented 5 years ago

As the operator also populates labels when it will generate k8s resources, then it is important that we align the rules/strategies between dekorate and operator and sync the next deliveries. Can we discuss this point today during the weekly call ? @iocanel

iocanel commented 5 years ago

Sure