search

dektar / ColorNamer

The code behind the ColorNamer app, https://play.google.com/store/apps/details?id=com.color.colornamer&hl=en
GNU General Public License v3.0
25 stars 41 forks source link

Add Flash - and removed code for invalid intent by android 4.4.2 #4

Closed CheatCoder closed 10 years ago

CheatCoder commented 10 years ago

I have Removed the intent, a normal app can't send the intent on android 4.4.x And add a little flash function for the camera that support flash

dektar commented 10 years ago

Thanks! I haven't had time yet to look into the android 4.4.x bug, I really appreciate that you found the issue there. I've had a few instances of it reported on it from the version in the Play store. I don't have my proper computer with me for a while, but I'll push out that update in mid January.

For the flash, great idea! I can't test it now, again because I'm separated from my computer, but it looks great. I added a few comments.

CheatCoder commented 10 years ago

Thanks, i will look for the issue and the menu for only flash is aviable ... So i will make it wait for the fix please :)

CheatCoder commented 10 years ago

I have found an other issue when i make the flash on - so the color pick don't work so i will look at it

CheatCoder commented 10 years ago

Now you can test it - found an way for the issue on 4.4.x and the flash works great on my phone

dektar commented 10 years ago

Testing this, it works really well on my device with a flash, but crashes my device that has no flash at SetParameters. I'll add some logic around only showing the flash option if the flash is available on the device.

Here's my issue: http://ikravchenko.blogspot.com/2013/09/nexus-7-2013-torch-issue.html

dektar commented 10 years ago

Thanks for setting this up. With a little tweaking, I got it working on my Nexus 7 too.

I've got it in 'alpha testing' in the play store. To become an alpha tester, join this community: https://plus.google.com/communities/116104509580474331098. Then follow the link to the pre-release version. It should be updated in a few hours with the new APK.

CheatCoder commented 10 years ago

Thanks for the Update. I can't join the communitie, only on invitation. when you want to invite me then please over my google+ account (google.com/+stefansauer-sow)

The issue is strange when getPackageManager().hasSystemFeature(PackageManager.PackageManager.FEATURE_CAMERA_FLASH) return true but the device has no flash.