dektronics / printalyzer-densitometer

Reflection and Transmission Densitometer for Photographic Darkroom Use
19 stars 4 forks source link

Improve implementation of "zero'ing" readings for desktop interaction #19

Closed dkonigsberg closed 2 years ago

dkonigsberg commented 2 years ago

The way the process of zero'ing a reflection or transmission reading currently works, is by a button sequence that calls a function in the firmware that simply sets the current reading as the active offset. This works fine for standalone device usage, but doesn't really interact cleanly with the desktop app.

The way this is implemented on device should be changed to a function that explicitly sets an offset, even if the button sequence still just sets it to the last reading. Then a series of command API functions can be called for the purpose of getting and setting this value directly. The presence of this offset should also be incorporated into the "extended" format for reporting readings via the the USB-CDC interface.

Once these pieces are in place, the desktop app should be updated to both show the presence of the "zero" offset and to be able to change its value.