search

dektronics / printalyzer-densitometer

Reflection and Transmission Densitometer for Photographic Darkroom Use
19 stars 4 forks source link

Test TinyUSB memory bug fix against known USB-CDC issues and update stack as needed #44

Open dkonigsberg opened 1 year ago

dkonigsberg commented 1 year ago

The TinyUSB project recently merged this fix of interest: https://github.com/hathach/tinyusb/pull/1789

One thing it claims to do is potentially fix this other issue: https://github.com/hathach/tinyusb/issues/1039

That issue was encountered during development of the densitometer's USB command interface, and is one of the reasons so much effort was put specifically tracking the DTR signal on the CDC device as a way of knowing when to use or ignore that interface.

It may also be related to this issue, for which we have a specific patch on top of TinyUSB to handle: https://github.com/hathach/tinyusb/issues/1128

It would be a good idea to merge these recent updates, temporarily disable all of our workaround, and do testing to see what happens now. Those upstream tickets can then be commented on if appropriate. Regardless, these latest changes should probably be merged the next time there's a firmware update.

dkonigsberg commented 1 year ago

Updates to the TinyUSB stack do not fix this issue. Those updates have been merged fw-1.1.0, but keeping this task open for now just so its not forgotten about.