dekvall / runelite-external-plugins

External plugins for RuneLite
BSD 2-Clause "Simplified" License
8 stars 16 forks source link

[Wise Old Man] - Plugin - Competitions #42

Closed BoomOSRS closed 2 years ago

BoomOSRS commented 2 years ago

Notifications Competition Notifications notifications are inconsistent with Login info notifications. image "Test has started!" should be "Competition Test has started!"

Also, perhaps Competition: {comp name} or WOM Competition {comp name} would be better than Competition {comp name} for these notifications.

Competition Timers When a competition starts during a login session, the Upcoming Competition timer disappears, and the Ongoing timer does not appear until you relog or toggle this feature off and on. See gif here: https://cdn.discordapp.com/attachments/696219254076342312/889268378664071168/YyoueTSq6Z.gif

Upcoming/Ongoing colour coding There's also no difference between the icon for 21:17 until a competition starts, and 21:17 until a competition ends. Perhaps they should be colour coded? Red numbers for upcoming or something? The white text is also quite difficult to read without Outline infobox text turned on within the rl settings, particularly for a Slayer competition. This should be considered when choosing potential text colours for colour coding.

Cluttered Infoboxes The infoboxes should be off by default, some members can be in multiple groups, and some clans run multiple competitions at the same time (for bingos, or dks competitions for example) This will get very messy/cluttered for users. After a quick check, I found this one user with 5 ongoing competitions, and 3 upcoming. That's 5-8 potential infoboxes which would be very crowded. image I know eventually we'd like to add a ui for competitions within the plugin, it would be great to be able to individually toggle which competitions have an infobox if/when this becomes an option.

dekvall commented 2 years ago

Implemented by b8593276497ce24420725f10b8ffb9ca24b75be2