dekvall / runelite-external-plugins

External plugins for RuneLite
BSD 2-Clause "Simplified" License
8 stars 18 forks source link

large logout: allow enlarging logout button on world switcher #97

Open Macweese opened 5 months ago

Macweese commented 5 months ago

This PR is intended to allow enlarging the logout button in the world switcher interface.

Changes include:

This is the first time I've done anything like this with widgets/interfaces, so if there are any poor practices/decisions (and in general) that can be improved, I'm happy to hear. One concern I have is whether the default config should be to always enlarge the world switcher logout, as I think a lot of users may be surprised/not know if it is this plugin that causes the change. So between driving support traffic to RuneLite Discord and 'informing' players of the plugin change by forcing it I picked the latter, I wanted to raise awareness of that.

Lastly, I opted for a somewhat larger logout design than the suggestion in the issue (# 59), I'm not very good with UI design but I thought it made sense if people want to be able to hit logout just as easily whether the mouse is over favorites or browsing the list.

I realize this PR is an enormous change (in a single commit too), I apologize in advance for that, it just snowballed that way and was unplanned.

Fixes #59

Demo

https://github.com/dekvall/runelite-external-plugins/assets/50101641/951991f4-055b-48f9-ae78-29173b5c7054