Allow per-folder authorization [willing to provide PR]

[iainbryson]

For a project we're doing, we'd like to filter the folder view by the user's authorization.

Essentially the idea would to add a configuration parameter for an (optional) function which would filter the folder contents based on auth. The interface would just be a filter; RFM-NODE wouldn't know anything about the user or authN/Z, just that this function removes certain directory contents.

Would such a feature be interesting as a PR?

[dekyfin]

This will be an interesting feature indeed. I think it will be more appropriate if it is implemented as an add-on plugin so others can utilize it along with RFM node.

On Wed, 22 May 2019, 11:51 Iain Bryson, notifications@github.com wrote:

For a project we're doing, we'd like to filter the folder view by the user's authorization.

Essentially the idea would to add a configuration parameter for an (optional) function which would filter the folder contents based on auth. The interface would just be a filter; RFM-NODE wouldn't know anything about the user or authN/Z, just that this function removes certain directory contents.

Would such a feature be interesting as a PR?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dekyfin/RichFilemanager-NODE/issues/14?email_source=notifications&email_token=AB6U2PWEN7DAB6SCNTE6XFLPWUXUDA5CNFSM4HOTPRC2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GVGCFQA, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6U2PU43UASCBSM5TV6UELPWUXUDANCNFSM4HOTPRCQ .

[iainbryson]

Can you elaborate what you mean by 'add on plugin' in this context? like a wrapping proxy, or...?

[dekyfin]

You can implement the feature as a node plugin which works with RFM Node

The node plugin can work in 2 ways:

1. As a sort of middleware for express.

2. As a wrapper/decorator for RFM Node

On Wed, 22 May 2019, 13:45 Iain Bryson, notifications@github.com wrote:

Can you elaborate what you mean by 'add on plugin' in this context? like a wrapping proxy, or...?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dekyfin/RichFilemanager-NODE/issues/14?email_source=notifications&email_token=AB6U2PVCYGJYE6QVSLTA6G3PWVE6DA5CNFSM4HOTPRC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV7C7EQ#issuecomment-494808978, or mute the thread https://github.com/notifications/unsubscribe-auth/AB6U2PVVYE2P3M56FS3NVLTPWVE6DANCNFSM4HOTPRCQ .

[iainbryson]

Hi there.

I've implemented 2. It requires a small PR . The wrapper itself is here.

Thanks!

[jlaustill]

It's not clear to me how the auth settings actually work from the README, but I love this idea.

On Fri, May 24, 2019 at 7:36 AM Iain Bryson notifications@github.com wrote:

Hi there.

I've implemented 2. It requires a small PR https://github.com/dekyfin/RichFilemanager-NODE/pull/15 . The wrapper itself is here https://github.com/dtu-compute/RichFilemanager-NODE-auth.

Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dekyfin/RichFilemanager-NODE/issues/14?email_source=notifications&email_token=ACSN3BYCDJZ2BNUITRHTYLTPW7VODA5CNFSM4HOTPRC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWFLZCQ#issuecomment-495631498, or mute the thread https://github.com/notifications/unsubscribe-auth/ACSN3B6E2MUC36UG6QMLQ4LPW7VODANCNFSM4HOTPRCQ .

-- { name: "Joshua Austill", status: "ttyl" }

[iainbryson]

Hi @jlaustill . I've updated the documentation, hopefully it's a little clearer now ;)

https://github.com/dtu-compute/RichFilemanager-NODE-auth

[jlaustill]

Hey @iainbryson that looks great and very straight forward, great work :)

[iainbryson]

@jlaustill Thanks! What remains for the Pull to be merged? I don't have write access, so can't do it myself.

[dekyfin]

Merged