Closed del82 closed 11 years ago
When creating a feature, it's required that fvalues
cannot be null. Should the user be selecting default values upon feature creation?
Or is fvalues
going to be some sort of dictionary with labels. For examples, for a single feature fvalues
would be ['feature-value-1' => true, 'feature-value-2' => false]
, for a multiple value ['feature-value-1' => 0, 'feature-value-2' => 1, 'feature-value-3' => 2 ... ]
etc.?
I've conceived fvalues
is a list (array) of possible values for the feature. So ftype
indicates the type of feature, (select one, select multiple, or string) and fvalues
is a list of the possible values the feature can be. There's no facility for selecting default values for a feature.
It occurs to me that it's not clear what fvalues
should be when the ftype
is string. It can't be nothing because as you say the validation requires that field to have something in it. So: change the validation or put some dummy value in fvalues
when ftype
is string (=2)?
Note also that there is a field feat_vals
in the hit record that is the place that the actual values of the features are stored for each individual hit. This is a {Feature.name => value(s)}
hash.
Speaking to the last commit, how should deletion be handled? Admins only, but within a feature, should we be able to delete an fvalue?
Let's worry about fvalue deletion when it becomes apparent we need to, i.e. when people start asking for it. Until then let's defer it, as you have done.
On Mar 29, 2013, at 19:55, parryc wrote:
Speaking to the last commit, how should deletion be handled? Admins only, but within a feature, should we be able to delete an fvalue?
— Reply to this email directly or view it on GitHub.
Administrators must be able to create and edit features.