del82 / ezra

ezra on rails
2 stars 1 forks source link

How about three buttons for the hit#edit interface, rather than just one? #47

Closed del82 closed 11 years ago

del82 commented 11 years ago

I propose that the "save changes" button be broken up into three: "Save and next", "Save", and "Cancel".

"Save and Next" is the default behavior now and will likely be the most used version, but I think users should also have the option of saving and not nexting. The cancel button is strictly speaking unnecessary but might make people feel better-- It could force a reload of the page (thereby resetting the hit data) or just be a link to target#show or some such.

I like the visual indication of when a hit has changed that the current button is giving us, and I'd like for that to be in the interface somewhere, but I think separating that from the save button is a good idea. This will also allow us to write request specs more easily without dealing with the weird problems with Capybara and change events in the browser.

Thoughts?

parryc commented 11 years ago

I agree, I think it's a good idea. I'm iterating through ideas on how to redo the annotator's interface (as per Neil's suggestions in other issues) and I'll incorporate this.

dealing with the weird problems with Capybara and change events in the browser.

As an aside - Capybara's (well, Selenium's) problems are with javascript's change events in terms of interaction - any real-time validation will have this problem with Capybara.

parryc commented 11 years ago

I have two of the three tests passing. I've made the other one pending ... I image it's some syntax problem, but I can't figure it out. I tried copying @del82's other examples, but they don't wanna gel.

parryc commented 11 years ago

Closed as of #58