search

del82 / ezra

ezra on rails
2 stars 1 forks source link

Add play button for target phrase only #70

Closed ancache closed 11 years ago

ancache commented 11 years ago

It would be nice to have a play button that will jump straight to the location of the target phrase within the audio, and play 1 or 2 seconds after that point. Annotators might not always need or want to listen to the entire context.

parryc commented 11 years ago

As of e55fbc8 I've added a play hit button that plays 2s around the front and end of the hit.

@ancache, reopen this and let me know if the time window is too large.

ancache commented 11 years ago

Ah, apologies, I didn't express this very well. I meant an interval of 1 or 2 seconds before and after the target. So if the target is "some people", I'd like to be able to listen to just "some people", without the context.

ancache commented 11 years ago

Thanks for the new button! The interval is way too big right now. I think it should actually start exactly at "mark hit" and end... say 700ms later.

del82 commented 11 years ago

Reopened to address @ancache's suggestion.

I haven't looked at how you implemented this @parryc; would it be easy to just let the user decide how much of the hit to play? If not, we can just change the numbers until we get something that works reasonably well for everyone.

parryc commented 11 years ago

It's implemented in the hits.js file, lines 68 and 69. The bounds +/- 2000ms just need to be changed appropriately.

It should be pretty easy to link some sort of "settings" menu to an AJAX hook that saves info like that to the Users model? Unfortunately, I'm not at a computer that can work on this for a little while... so maybe we defer a more comprehensive User settings until later, unless @del82, you want to work on it?

On Fri, Jun 14, 2013 at 10:22 AM, David Lutz notifications@github.comwrote:

Reopened to address @ancache https://github.com/ancache's suggestion.

I haven't looked at how you implemented this @parrychttps://github.com/parryc; would it be easy to just let the user decide how much of the hit to play? If not, we can just change the numbers until we get something that works reasonably well for everyone.

— Reply to this email directly or view it on GitHubhttps://github.com/del82/ezra/issues/70#issuecomment-19463444 .

del82 commented 11 years ago

Closing this again, but issue #77 addresses making this window customizable.