delVhariant / illumination

Small Module for Foundry VTT that ties Global Illumination to the scene Darkness level.
MIT License
3 stars 5 forks source link

Color Change Error #12

Closed bibicvc closed 4 years ago

bibicvc commented 4 years ago

When moving from dawn to day to dusk to night, the color and darkness level change as intended for the DM.

For the player, the darkness level changes correctly but the color change is inconsistent. Sometimes the color does not change. At other times the color changes to the wrong color. This is fixed if the color change is also accompanied by a change in global illumination. I have attached a picture of my settings in case this is relevant, but fiddling with any setting apart from "Link Global Illumination" does not appear to change this behavior. The intended behavior is that the color changes for the player as it does for the DM.

image

delVhariant commented 4 years ago

Hi @bibicvc, the latest version pushed to Foundry (0.3.1) should fix this issue, can you confirm you're still getting the issue on that version?

bibicvc commented 4 years ago

Yes, I am using 0.3.1 and still get this error. To be more precise in reproducing it:

Click on darkness - normal behavior Click on darkness, then dusk - normal behavior. Click on darkness, then dawn - normal behavior Click on darkness, then daylight - normal behavior Click on darkness, then dusk, then dawn - dawn has expected illumination but dusk color. Click on darkness, then dawn, then dusk - dusk has expected illumination but dawn color Click on darkness, then daylight, then dawn - dawn has daylight illumination and color Click on darkness, then daylight, then dusk - dusk has daylight illumination and color

All the incorrect transitions only appear for the player, they work properly for the DM.

delVhariant commented 4 years ago

Ah thanks, I understand. I'll try and get it fixed ASAP

delVhariant commented 4 years ago

@bibicvc , I've just released the fixed version on Foundry, please let me know if you continue to have any issues

bibicvc commented 4 years ago

Works great, thanks for the awesome mod!