delaford / game

⚔️ An online JavaScript 2D Medieval RPG.
https://play.delaford.com/?useGuestAccount
MIT License
1.32k stars 843 forks source link

Fix smithing errors. and Updated smith getter. #206

Closed SaintBert closed 11 months ago

SaintBert commented 1 year ago

Description

Anvil will now smith the med helmet. Anvil now supports armor smithing in general. Bronze sword did not smith due to missing ID this was the same with the helmet armor which then made me realise that armor is not properly supported for forging.

Only “bronze-med-helmet” currently is supported due it being the only armor set available in the smithing list thus I made an assumption that the intended results was to allow smithing for this item. I also added ‘type’ to ‘getItemsToSmith()’ to differentiate between armor/weapon.

Related Issue

Motivation and Context

It was the first bug encountered when playing the game, and attempting to smith items thus I made an attempt to improve user experience.

How Has This Been Tested?

Q&A (manual testing) Tested on Ubuntu 21.04 and Windows 10 Home

Screenshots (if appropriate):

Types of change