New version 2014/11/27 - Githubissues

ViperCode7 commented 9 years ago

I've fixed and improved the 2.8 official version and here's the changelog:

fixed locations for both user and business pages
fixed albums not loading on some pages
fixed user name not being found on album page
improved interface by adding default selections to options
improved interface by adding default path (that of default Download dir, IMPORTANT: such a dir must be selected in Firefox options)
unfixed bug: there still are some minor cosmetic issues when default page address is just /photos, that Photos is listed as being Photos of and not Photos by or vice versa depending on what the user has as default for Photos
unfixed bug: if the user has no Photos, but just the Albums tab the proper procedures won't be loaded, the user has to click on Albums title link in the page to reload that page but with proper address in order to make it work.

Other than that, as far as I was able to test it, it works fully.

Download link, drag and drop on the main folder, it should override any old facepaste versions: https://www.dropbox.com/s/wf8jfbwwd74a3i7/facepaste-2.9-fx.xpi?dl=0

Please report bugs for my fixed version of facepaste here, on this thread, not on the main forum.

ViperCode7 commented 9 years ago

The dropbox links doesn't need an account, just continue the download without an account, if anyone is asking.

Also, I've mailed some people about this, IDK how the emails were sent but they showed multiple times in my sent folder with the same senders. If so, it's not meant as spam and I apologize.

Alex-Esko commented 9 years ago

Thanks for the mail and your improvements, emm980. Also regards fly out to Azabani, the original author of this tool.

Version 2.9 did work out perfect at a german page album.

josh5671 commented 9 years ago

Thank you, I just read your mail~ Take a test later on~

noxxim commented 9 years ago

Thank you.

josh5671 commented 9 years ago

wow, work very well...

josh5671 commented 9 years ago

Found a little problem. When get from a page with large amount album (100++) It sometime cant get all album. maybe 20 came out.

And the plugin have a little hard on 'parsing album index' that cause it stopped download

ViperCode7 commented 9 years ago

I've tried it on a page album and it listed all albums (about 120), as well as downloaded pictures of selected albums (24) except some, I presume those are on servers which are in maintenance right now as they don't work on the actual facebook either.

If you have an example link: em (dot) dev (at) outlook com

josh5671 commented 9 years ago

hmm, That not always happen (maybe random). So I didn't catch what cause the problem.

But there also another i think cause by link

example: www.facebook.com/pages/(name of page)/200579986694754?sk=photos_stream&tab=photos_albums

when a page have a ID the plugin cant get album list, only get photos by xxx

noxxim commented 9 years ago

Why you don't change the source here in this repository? Everybody release his own fixed version. Or better start a Fork.

About facebook uri's that change: Best way is to let the addon fetch a actual list of search patterns from the Server. So you can change the regex instantly and without updating the addon. I know some addons that do so. You only need to get permissions for the cross-origin request. Just an idea for feature version plans.

Maybe if i have more time in the future, i will try to port it for Chromium. I don't use Firefox anymore (except downloading fb-albums).

sorry for bad english

ViperCode7 commented 9 years ago

@noxxim, the repository version is old and a new type of facepaste was supposed to be in the works, 2nd sometimes what others think is right, for me it's not, thus I make my own copy, 3rd I don't use github so no reason to fork anything, 4th porting it to chrome is a waste of time unless you're willing to pay google for a dev account, other than that, to load extensions coming outside of webstore, you'll have to jump some big hoops like using beta/nightly Chrome or have to endure popups which basically disable the extensions on their own without you having a say in it, NO!

@josh5671, can't be done or I don't know much about it to use it for general release. You could modify your own files if you want to, but notice that it will looses checks and might introduce other failures where previously it wouldn't.

The problem is in overlay.js, mainly the regex part. When it checks the URL's (location) I've set rage of characters to contain only latin alpha numeric from a to z, 0 to 9. The (name of page) in your link is actually in unicode asian, and I don't know if the javascript engine of Firefox has a regex capable to understand unicode. If I use it with the /u flag for unicode, Firefox says it doesn't understand it.

Loosen this check: /(\?|&)sk=photos_albums(&|$)/.test(content.location.search)

and allow it to contain tab= as well as sk=: /(\?|&)(sk|tab)=photos_albums(&|$)/.test(content.location.search)

Repack overlay.js, reload Firefox and you're good to go.

josh5671 commented 9 years ago

@emm980 Here i attach the link, which is public page. you may take a look. https://www.facebook.com/pages/Daphne-Laven/302543426471720?sk=photos_stream&tab=photos_albums

I try your solution later on

noxxim commented 9 years ago

@emm980

A Google Dev Account costs only 5 Dollars.
On my Linux Chromium (the open source project of Chrome), extensions that are installed manually from any source runs without any problem.
Only the Windows Chrome (>= v33) disables non-playstore extensions. http://www.chromium.org/developers/extensions-deployment-faq

Thanks for the RegEx.

adityaiit commented 9 years ago

It is not working on facebook pages with the link in the following pattern

www.facebook.com/pages/(name of page)/200579986694754?sk=photos_stream&tab=photos_albums

ViperCode7 commented 9 years ago

Right now I don't have spare time to add this but to make the ext work on pages where the url is not in form of facebook.com/name but is in form of facebook.com/page/name see my reply to josh5671, there is the change needed to make it work.

Once I have some time I'll rewrite the URL test part to make it work properly, also got some idea to fix those bugs I mentioned in original post and hopefully make this URL business go away for good.

Eraser099 commented 9 years ago

It does work someway, but I can notice a problem related to photo album browsing, both on Firefox and Chrome, after I do use of Facepaste: even after a few minutes of pics download session from the fb album pages, at my subsequent log in (on fb), I can see pages conceal the access to the single albums and/or the actual number of pictures stored in every single album (this happened after the last download session). Maybe fb servers consider the facepaste batch download as a form of hacking and then, as a consequence, try to prevent it downloading pics?

b3bis commented 9 years ago

I don't believe it is considered a hack, it is considered a batch download (as it is indeed), something which by the TOS is not really what you would consider the most acceptable thing taking into consideration that generally (if I can recall well enough) the use of software which does not use the FB api is not acceptable. Anyway, me too had seen some minor problems while and after using the extension (I have not used it during the last month or so though). They may have implemented some form of image uri requests per second, though not something far from this.

Eraser099 commented 9 years ago

It looks like changes about the number of pics contained in every single album is a new permanent change, since a few people I know have been experiencing the same thing. According to your words, batch download of pics is not considered the most acceptable thing... you think people who does batch download, not more than once per month, can be persecuted or at least banned from their servers? I guess admins are aware about who's the one who's downloading...

josh5671 commented 9 years ago

Facebook seen change something again?..

These few weeks batch download all stuck on downloading (lime green color block)

TrueTenacity commented 9 years ago

Not sure if it was FB or firefox that changed...

I was downloading like a demon yesterday, this morning I updated firefox and now also getting the stuck on downloading...

On 5 March 2015 at 12:39, josh5671 notifications@github.com wrote:

Facebook seen change something again?..

These few weeks batch download all stuck on downloading (lime green color block)

Reply to this email directly or view it on GitHub https://github.com/delan/facepaste/issues/22#issuecomment-77342185.

josh5671 commented 9 years ago

@TrueTenacity Maybe I try rollback some old version firefox and take a test

Xaemyl commented 9 years ago

Yeah its firefox 35-36 that broke it. I rolled back to firefox 34.0.5 for the time being and it works again (although it does stall on pages with lots of albums on it, so have to download a few albums at a time).

DavePlater commented 9 years ago

Ok. I think I fixed the "stuck downloading" bug. The problem seemed to be that progressListener no longer triggers the "i am done" message. The first 8 files download but that is it. So i took emm980 's version and switched it over to using the Downloads.jsm Also added some quick options for how many photos to download at a time (was hardcoded at 8 before) At any rate, it works in FF 36.0.4 (my version requires FF 26 or better)

Download link, drag and drop on the main folder, it should override any old facepaste versions: https://www.dropbox.com/s/dffibvvw4lc01nv/facepaste-2.9b-fx.xpi?dl=0 (Or use the 'Install Add-on From File' in the Add-ons Manager)

NOTE: If you are having trouble with the version with the options screen, try this one: https://www.dropbox.com/s/pd1pocbme5985g3/facepaste-2.9b-nop-fx.xpi?dl=0

TrueTenacity commented 9 years ago

Hi Dave,

I tried your new version and it doesn't seem to work... might be because of me being behind a proxy or something... but its not downloading the album list or letting me browse to pick a folder to download to.

FF 35.0.1 / Windows 7 x64

On 27 March 2015 at 08:14, DavePlater notifications@github.com wrote:

Ok. I think I fixed the "stuck downloading" bug. The problem seemed to be that progressListener no longer triggers the "i am done" message. The first 8 files download but that is it. So i took emm980 's version and switched it over to using the Downloads.jsm Also added some quick options for how many photos to download at a time (was hardcoded at 8 before) At any rate, it works in FF 36.0.4 (my version requires FF 26 or better)

Download link, drag and drop on the main folder, it should override any old facepaste versions: https://www.dropbox.com/s/dffibvvw4lc01nv/facepaste-2.9b-fx.xpi?dl=0

Reply to this email directly or view it on GitHub https://github.com/delan/facepaste/issues/22#issuecomment-86838260.

maciex commented 9 years ago

I does not work for me either. It also stuck on downloading the album list.

FF 36.0.1

DavePlater commented 9 years ago

Well shoot. When it fails to load the album list, does the cancel button "not work" and you have to close with the X ? That means the javascript is broken. For a quick check, go to the Add-ons Manager (Ctrl+Shift+A i think?) and go to the Options for facepase. Check and uncheck the box and change the number setting. I suspect the default values are NOT being set and the javascript breaks because of it.

TrueTenacity commented 9 years ago

You are correct, have to use the X...

I changed the settings and it seems to be working now...

On 27 March 2015 at 13:32, DavePlater notifications@github.com wrote:

Well shoot. When it fails to load the album list, does the cancel button "not work" and you have to close with the X ? That means the javascript is broken. For a quick check, go to the Add-ons Manager (Ctrl+Shift+A i think?) and go to the Options for facepase. Check and uncheck the box and change the number setting. I suspect the default values are NOT being set and the javascript breaks because of it.

Reply to this email directly or view it on GitHub https://github.com/delan/facepaste/issues/22#issuecomment-86906988.

maciex commented 9 years ago

After changing the settings the "Cancel" button still doesn't seem to work. Also the plugin itself doesn't download the album list.

The error in JavaScript console is: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get] facepaste.js:28:0

DavePlater commented 9 years ago

The settings bug was because i changed a setting name but didnt fix it in the defaults, re-uploaded with a fix for THAT problem. @maciex are you on a page that would find the albums with emm980's version? www.facebook.com/{user-page}/photos ??

maciex commented 9 years ago

@DavePlater: I now installed the reuploaded version from dropbox and tried on page https://www.facebook.com/aksienionek.szymon/photos

I still got the error in Browser console: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get] facepaste.js:28:0

Cancel buttont also doesn't work.

DavePlater commented 9 years ago

Hmm, best I can figure your system doesn't have the properties/settings service ready by the time I call it. Probably my fault for not doing some kind of "wait" to change when it loads in the lifecycle. I can probably just repackage an "option-less" version that has the download fix and none of my extra goodies. What OS are you on? Also, how did you find that error? I've been pretty much doing this all blind with no ability to see errors or output (which is why it took me way longer than it should)

maciex commented 9 years ago

W dniu 27.03.2015 o 14:42, DavePlater pisze:

Hmm, best I can figure your system doesn't have the properties/settings service ready by the time I call it. Probably my fault for not doing some kind of "wait" to change when it loads in the lifecycle. I can probably just repackage an "option-less" version that has the download fix and none of my extra goodies.

That would be nice, as a quick fix. I think the default values are fine for me.

What OS are you on?

GNU Linux (Arch) x86_64 Kernel 3.19.1-1-ck

Also, how did you find that error? I've been pretty much doing this all blind with no ability to see errors or output (which is why it took me way longer than it should)

I used Browser Console. It will show you all JavaScript errors. https://developer.mozilla.org/en-US/docs/Tools/Browser_Console

Pozdrawiam

Maciej Sitarz

DavePlater commented 9 years ago

I edited my original post to have the option-less version as well, but here it is again: https://www.dropbox.com/s/pd1pocbme5985g3/facepaste-2.9b-nop-fx.xpi?dl=0 Hopefully that one will work

interceptorchamp commented 9 years ago

Hello, I installed your newest version however I can´t seem to get it work. I´m using Firefox 36 on Win7 64. Like the previous versions, facepaste gets stuck when trying to download 8 pics in lime green color. The size of these files on my HDD is 0 KB.

Can you picture out what is wrong? The previous version up to approx. 6 weeks ago worked fine.

I recommend that you put a link on the main page to make it easier to find this update page.

Greetings from Germany

ViperCode7 commented 9 years ago

You could look up handle_photo_page and see what's not working. I got img null on "photos by" page. It seems neither fbPhotosPhotoActionsItem nor .fbPhotoImage is there thus p.photourl always gets to nothing.

Getting r.response.body content all I got was This content is currently unavailable. err

Also it's strange that !link && !img gets passed... in the case above I was expecting to see that p.log( 'error... pop up.

The first release, with options, did not work, until I applied the changes to the options, then it downloaded several albums completely with no issue.

Now, on a different user page it seems it can't get that p.photourl...

It's very annoying when fb uses several versions of their software to push pages, all working differently.

Here are two plain users, one is working (pandor.ioana, has fbPhotosPhotoActionsItem in r.response) and the other one is not working under any circumstance (miha.mihaela.56).

DavePlater commented 9 years ago

Using: Windows7 32Bit Locale: en-US Firefox: 37.0.1 And FP: 2.9b-nop

I downloaded the albums from (miha.mihaela.56) and (pandor.ioana) just fine. However, (aksienionek.szymon) found the album but claimed there were no photos inside to download.

interceptorchamp commented 9 years ago

I tried to download an album from both facebook users, and both stuck in lime green after 8 files, each of 0 Bytes length :( The folders are created correct.

Any ideas what I could do to get it fixed?

DavePlater commented 9 years ago

@interceptorchamp If you are using the plain 2.9 version at the top of this thread, it will stall out like that. Look for my two links to versions 2.9b and 2.9b-nop

josh5671 commented 9 years ago

I think the 2.9 work well in newer version firefox. but somehow the pages album are not listed in album. only 'Photo by...'are shown

Xaemyl commented 9 years ago

Also 2.9 doesnt seem to be able to download pages videos anymore.

ViperCode7 commented 9 years ago

The way facebook versions pages based on language/location makes it difficult to track what does and what doesn't work.

It's a good project, if fb hadn't removed ways in their API to obtain certain data... now mostly addons might work on single pages where the whole data is already set by the page itself. FB Album mod still works alright, it's not a complete solution, but it should be able to counter changes and limitation.

interceptorchamp commented 9 years ago

I am having the same issue with video pages. Pictures run fine. Videos are not being downloaded anymore, but it worked some months ago. Can you figure out what was changed by facebook?

interceptorchamp commented 9 years ago

Hello,

during the last few days, facepaste shows after fetching the album index for some time "found 0 photos" and terminates the execution, although my LAN Gadget shows some traffic in both directions (upload and download).

This happens in different user profiles, independently of the geographical Location.

Do you know of recent changes of Facebook which causes the described issues?

I would appreciate your help to make facepast work again.

josh5671 commented 8 years ago

Anyone going to update the code, which this few month facebook update their code...

DavePlater commented 8 years ago

I've been working on it, will post a new thread with what I've got. I don't think it will fix everyone's issues. But it fixed the ones I was having.

interceptorchamp commented 8 years ago

Great! I appreciate you effort in keeping us updated :-)( I´m looking forward to give it a try ...

b3bis commented 8 years ago

I 've been watching the modifications and done one or two myself but now it does not seem to work at all. It gets to a 500 error for every photo (albums are detected just fine). I could help with the programming part but I know almost nothing about ff extensions.

Also on firefox add on page there is a facepaste-reload addon that claims to be what is done here but doesn't seem to incorporate the video inclusion changes. Also trying that add-on I got the same results but with an error asking if I have 3rd party cookies enabled (which I have) if this is of any help.

Also, shouldn't we try to combine forces with whoever updates that extension?

delan / facepaste

New version 2014/11/27 #22

Pozdrawiam