delano / rye

Safe, parallel access to Unix shells from Ruby
http://delano.github.com/rye
MIT License
234 stars 32 forks source link

Feature/capture parallel set exceptions #14

Closed drichert closed 12 years ago

drichert commented 12 years ago

If I ran into a timeout or other exception when running commands via Rye::Set in parallel, it would prevent me from getting results for the rest of the boxes in the set.

This change saves any exceptions in a Rye::Rap and appends it to the results.

Wasn't clear on how your test suite works. I'll gladly add tests if you could provide some guidance.

delano commented 12 years ago

Looks great. I'll pull this in now.

The tests are in try/ and tested with Tryouts. The test description and result are in comments which is unconventional but I prefer it b/c the tests double as example code.

https://github.com/delano/tryouts

ruebot commented 12 years ago

drichert++