search

delano / rye

Safe, parallel access to Unix shells from Ruby
http://delano.github.com/rye
MIT License
235 stars 32 forks source link

Stderr channel from Net:SSH:Buffer not being read from correctly. Error messages from Rye::Set commands are lost. #32

Closed megeek closed 11 years ago

megeek commented 11 years ago

I'm using Rye::Set and std error from commands are not being stored in the Rap correctly. This issue is that the code (line 826, 827 in box.rb):

rap.add_stdout(channel[:stdout].read || '') rap.add_stderr(channel[:stderr].read || '')

is reading from the end of the Net:SSH:Buffer object (channel). I've added the code necessary to fix this in this pull request.

Thanks!

delano commented 11 years ago

Thanks for the fix.

delano commented 11 years ago

I finally pushed a new release (0.9.9) with this change. Thanks again.

megeek commented 10 years ago

No worries! Glad to be of service. Thanks again for accepting it! :)