search

delano / rye

Safe, parallel access to Unix shells from Ruby
http://delano.github.com/rye
MIT License
234 stars 32 forks source link

string_upload fails silently #50

Closed cschwartz closed 10 years ago

cschwartz commented 10 years ago

Hi, I've recently started using Rye (thanks for the great work, by the way) and noticed that Cmd#string_upload fails silently.

After some digging I found that Box#net_scp_transfer! requires an recursive argument, which string_upload does not pass (thus net_scp_transfer takes the passed paths as the recursive argument, and the empty array as paths) resulting in no uploads. This is fixed in commit 3938059.

Commit 607ce23 fixes the same problem for Cmd#string_download.

If you require any further changes before including my fixes, please let me know, I'd be happy to help.

Best regards, Christian

delano commented 10 years ago

Awesome, thanks. It'll be in the next release.