delano / rye

Safe, parallel access to Unix shells from Ruby
http://delano.github.com/rye
MIT License
235 stars 32 forks source link

Remove usage of stty if not needed #54

Closed mingers closed 10 years ago

mingers commented 10 years ago

using stty commands in an non interactive terminal will cause errors to be thrown like this

'stty: standard input: Invalid argument'

When using Rye as part of automated scripts that are run by a non interactive shell (like jenkins for example), and on a lot of hosts - this gets very messy and fills the output with noise.

I don't see the variable storing the result of this stty command being used anywhere - so I'm proposing its removal.

delano commented 10 years ago

Ah, I see what you mean. I actually use the value in another project. Could you submit another PR that conditionally calls it depending on the result of STDIN.tty?.