search

delano / rye

Safe, parallel access to Unix shells from Ruby
http://delano.github.com/rye
MIT License
235 stars 32 forks source link

remove Timeout.timeout (for review) #64

Closed rubemz closed 1 year ago

rubemz commented 9 years ago

Removing due to http://blog.headius.com/2008/02/ruby-threadraise-threadkill-timeoutrb.html and http://www.mikeperham.com/2015/05/08/timeout-rubys-most-dangerous-api/

We're having some instability in sidekiq production and it may be related to timeout usage.

rickhull commented 8 years ago

+10

delano commented 8 years ago

Looks like a great fix. If you submit again with the whitespace changes checked in separately, I'll pull it in.