search

delano / rye

Safe, parallel access to Unix shells from Ruby
http://delano.github.com/rye
MIT License
234 stars 32 forks source link

"System cannot find the path specified" error at Rye::Box.new() on Windows #70

Open zinga666 opened 7 years ago

zinga666 commented 7 years ago

When using Rye on Windows (which works great by the way!) there's always an error message System cannot find the path specified when initializing a Rye::Box.

I guess this is because of

@rye_stty_save = `stty -g 2>/dev/null`.chomp rescue nil

which could probably be changed to something like

@rye_stty_save = `stty -g 2>/dev/null`.chomp unless Rye.sysinfo.os == :windows rescue nil

in Rye::Box (and also in Rye::Hop I guess).

I didn't make a PR because it seems like there is already a pending PR #56 which also works on that code (on a slightly different matter) and recently there seems to be no more activity in the repo. I'd be happy to make one though if there's still interest...

delano commented 7 years ago

Thanks for bringing this back on the radar.

Can you check if the change on that PR works for you? Usingif STDIN.tty? rescue nil instead of checking the OS.

zinga666 commented 7 years ago

Hey, thanks for the reply!

Can you check if the change on that PR works for you? Usingif STDIN.tty? rescue nil instead of checking the OS.

Oh, forgot to mention that I already did that - and well, no, it doesn't work because STDIN.tty? returns true on Windows as well.

So, when doing both checks this might be a little bit much/rather unreadable for a one liner... ;-)