delashum / obsidian-checklist-plugin

MIT License
390 stars 42 forks source link

Checklist not rendering any items after upgrading to 2.2+ #142

Closed chrisgmbishop closed 2 years ago

chrisgmbishop commented 2 years ago

Hey @chrisgmbishop I'm going to close this issue as based on some other comments people have left the original issue described here has been fixed.

If you are continuing to face issues could you please open a new issue with as much details as you can give on the problem. Preferably including obsidian version, checklist version, your hardware, and screenshots if possible. Thank you!

Originally posted by @flankstaek in https://github.com/delashum/obsidian-checklist-plugin/issues/139#issuecomment-1190280225

I'm on Obsidian 0.15.6 Checklist 2.2.3 Macbook Pro M1Pro

chrisgmbishop commented 2 years ago

What is showing: Screen Shot 2022-07-20 at 17 59 47

My typical Task block: Screen Shot 2022-07-20 at 18 00 31

My Settings: Screen Shot 2022-07-20 at 18 00 52

chrisgmbishop commented 2 years ago

I have many other open tasks in other files that used to render here and are now no longer

flankstaek commented 2 years ago

Would you mind sharing the exact list of tags you are sorting for (copy your whole list and paste here)?

In addition, the items shown in your screenshot would not show up in this example as you have "Show Completed" unchecked and are only showing a completed task & an empty task. A task with no body will not show up in the sidebar.

chrisgmbishop commented 2 years ago

Would you mind sharing the exact list of tags you are sorting for (copy your whole list and paste here)?

In addition, the items shown in your screenshot would not show up in this example as you have "Show Completed" unchecked and are only showing a completed task & an empty task. A task with no body will not show up in the sidebar.

Sorry, below the OP I note that I have plenty of other notes with incomplete tasks that have a body that previously showed.

I have tested for an overactive 'show Completed' by switching the setting and had no difference.

The initial tags I had were task tasks

And have since tried accounting for case sensitivity and added two more. So the list is: task tasks Task Tasks

Thanks

flankstaek commented 2 years ago

I'm not able to replicate this behavior. In addition the tag name shouldn't be case sensitive.

I can see in the pane that it's not loading all of your included tags though as the output is only listing "#task #task" and none of your other included tags, so if you wouldn't mind downloading the latest update & trying to re-enter your tags after deleting all text in the included tags box. After resetting the window please try reloading the app and confirming it's still not working.

If it still isn't working would you be able to open the dev console (Command+Option+J) and modify some tasks and see if any errors are output. Thank you!

chrisgmbishop commented 2 years ago

No luck after attempting those measures. I've copied what I've found in the Dev console. Looks like an issue with the parameter going into .toLowerCase Screen Shot 2022-07-22 at 10 44 59

And the resulting location in the JS Screen Shot 2022-07-22 at 10 44 15

Does this help?

flankstaek commented 2 years ago

That does help - it appears as though you might have some malformed tags present, or at least tags that the plugin was not handling correctly.

I've added an attempted fix, try the latest release and let me know if it fixes it.

chrisgmbishop commented 2 years ago

First thank you for your time on this.

I was getting no errors after updating and wiping and readding the tags I decided to qipe the slate clean. I uninstalled the plugin, reinstalled and am now getting a different error once I've set everything back up the way it was: Screen Shot 2022-07-22 at 13 55 57

And: Screen Shot 2022-07-22 at 13 56 36

tristancade commented 2 years ago

Having the same issue. Purely observational, but it seems that the issue starts once you get past a certain number of list items for a particular tag (maybe 15ish entries or so.)

flyingbirdhub commented 2 years ago

First thank you for your time on this.

I was getting no errors after updating and wiping and readding the tags I decided to qipe the slate clean. I uninstalled the plugin, reinstalled and am now getting a different error once I've set everything back up the way it was: Screen Shot 2022-07-22 at 13 55 57

And: Screen Shot 2022-07-22 at 13 56 36

i submit a PR: https://github.com/delashum/obsidian-checklist-plugin/pull/145, for this problem, it may be solved by this PR.

chrisgmbishop commented 2 years ago

Having the same issue. Purely observational, but it seems that the issue starts once you get past a certain number of list items for a particular tag (maybe 15ish entries or so.)

I can confirm, I definitely have more than 15 entries

flyingbirdhub commented 2 years ago

Having the same issue. Purely observational, but it seems that the issue starts once you get past a certain number of list items for a particular tag (maybe 15ish entries or so.)

I can confirm, I definitely have more than 15 entries

the problem you describe may be is different. the solved bug is not caused by number of todo entries, just because of some embed inline images. you can try it

llathieyre commented 2 years ago

I have the same issue, none of my tasks are rendered anymore. I can't pinpoint to a specific event (may be a plugin upgrade)

Checklist 2.2.5 Obsidian 0.15.9 (installer 0.15.8) MacOS

vilcansu commented 2 years ago

Having the same issue.

Obsidian Version 0.15.9 (installer 0.15.9) Checklist 2.2.5 macOS Monterey.

P.S. I love the plugin and many thanks for creation and maintenance! Screenshot 2022-08-03 at 09 49 52

kevindantoine commented 2 years ago

Hi, all. I'm having the same issue. No checklists are being rendered. Are there any fixes? First, the "#todo" broke for me and I started using "#td", I made some changes to sliding panes just a few minutes ago and my checklists are no longer available. The same issue as the first "#todo" break: "No checklists found for tags: #td #todo"

tristancade commented 2 years ago

@kevindantoine yep yep, @flyingbirdhub had the fix. Thank you btw! 😀 As soon as I removed inline embeds from the lists, they were selectable again with all items showing up.

kevindantoine commented 2 years ago

@kevindantoine yep yep, @flyingbirdhub had the fix. Thank you btw! 😀 As soon as I removed inline embeds from the lists, they were selectable again with all items showing up.

I removed mine and no tags are working, reinstalled and still no luck :(

flankstaek commented 2 years ago

Appreciate everyone's feedback - I've merged the code from @flyingbirdhub. Please update versions and see if that fixes it.

kevindantoine commented 2 years ago

Appreciate everyone's feedback - I've merged the code from @flyingbirdhub. Please update versions and see if that fixes it.

Updated, still no luck on my end.

llathieyre commented 2 years ago

a []() link works a [[]] internal link breaks it

kevindantoine commented 2 years ago

a []() link works a [[]] internal link breaks it

Thank you! I ended up doing a vault search and removed all my backlinks, pdfs and other embedded files as well as brackets and I am happy to announce that it is WORKING!

You only know what you have when it's gone! Where can I tip the active devs??

flankstaek commented 2 years ago

Sorry just to confirm - internal links in the todo are breaking?

llathieyre commented 2 years ago

yes Laurent Lathieyre http://www.linkedin.com/in/llathieyre {he|him} | @.*** | | Seattle, WA

On Wed, Aug 3, 2022 at 12:23 PM Ian @.***> wrote:

Sorry just to confirm - internal links in the todo are breaking?

— Reply to this email directly, view it on GitHub https://github.com/delashum/obsidian-checklist-plugin/issues/142#issuecomment-1204380325, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAJH4TDKELCFLIT4QWYTW3VXLBL3ANCNFSM54FBP24A . You are receiving this because you commented.Message ID: @.***>

tristancade commented 2 years ago

That's a great call @llathieyre ! @flankstaek For me, simply removing the ! from in front of the [[]] links did the trick. Still have quite a few internal links throughout my lists, just no more embeds. Hopefully that helps anyone who's still dealing with the bug. @delashum Love this plugin, the functionality is so needed! Thanks so much for your hard work! 🙏

flankstaek commented 2 years ago

Thank you! Got it, embedded links are 100% causing failures. As for active devs these days it's primarily just me maintaining the plugin.

I will work on getting a fix for inline embeds during the week - if anyone has any OTHER issues please create a new issue detailing the problem as detailed as possible.

flankstaek commented 2 years ago

Actually I was able to figure out what was still causing the issue - you can have inline embedded links in your todolist now. Please update and let me know if that fixes it.

chrisgmbishop commented 2 years ago

Latest upgrade nuked my bug as well. Awesome work! thank you for this stellar plugin.