search

delashum / obsidian-checklist-plugin

MIT License
373 stars 39 forks source link

Obsidian freezes and crashes if Tag name setting is empty #188

Open oscartorres-10 opened 5 months ago

oscartorres-10 commented 5 months ago

Steps to reproduce

  1. not confirmed: Have a vault with a considerable number of files (mine is 5316 at time of creating this issue, 771 markdown files)
  2. Install Checklist plugin
  3. Go to Checklist plugin settings
  4. Look at first section "General"
  5. Look at "Tag name" setting
  6. Empty the field, so it will scan all the files

Did you follow the troubleshooting guide? [Y/N]

Yes.

Expected result

Actual result

  1. Obsidian freezes after 10-20 seconds, impeding for example to create new notes
  2. Following error appears on console

Obsidian Checklist plugin error Uncaught (in promise) RangeError Invalid string length at readFileHandle (node internal original-fs promises 496 25)

  1. 5-10 seconds later, Obsidian gives blank screen and execution with message "Paused before potential out-of-memory crash".
  2. Vault gets completely locked and need to restart app

    Environment

SYSTEM INFO:

Obsidian version: v1.5.3 Installer version: v1.4.16 Operating system: Darwin Kernel Version 23.2.0: Wed Nov 15 21:55:06 PST 2023; root:xnu-10002.61.3~2/RELEASE_ARM64_T6020 23.2.0 Login status: logged in Catalyst license: insider Insider build toggle: on Live preview: on Base theme: adapt to system Community theme: none Snippets enabled: 2 Restricted mode: off Plugins installed: 19 Plugins enabled: 19

1: DataLoom v8.15.11 2: Excalidraw v2.0.18 3: Importer v1.5.6 4: Projects v1.17.1 5: Advanced Merger v1.5.0 6: Tasks v6.0.0 7: Zotero Integration v3.1.7 8: Notes dater v1.0.1 9: Global Search and Replace v0.3.0 10: Better Word Count v0.10.1 11: Dataview v0.5.64 12: Style Settings v1.0.7 13: Hider v1.3.1 14: Recent Files v1.3.10 15: Settings Search v1.3.10 16: File Explorer Note Count v1.2.1 17: Kanban v1.5.3 18: QuickAdd v1.6.1 19: Mononote v1.1.1

Additional information

As I mentioned at the beginning, one of my theories is that it has to do with the size of the vault, as I couldn't reproduce the issue on a Sandbox Vault with the same configuration of plugins (copied .obsidian folder), neither on a new vault with only the Checklist plugin installed.

Video:

https://github.com/delashum/obsidian-checklist-plugin/assets/38195378/214e5606-7144-4527-8132-474cd8afc021