search

delb-xml / cff-from-621

Derive a CITATION.cff from a pyproject.toml file's contents.
4 stars 0 forks source link

Compatibility with Poetry-based projects #1

Open amotl opened 1 year ago

amotl commented 1 year ago

Dear Frank and Martin,

thanks a stack for conceiving this excellent package.

@gutzbenj recently added it to Wetterdienst on behalf of https://github.com/earthobservations/wetterdienst/pull/841, with some minor adjustments to make it compatible with Poetry. So, I wanted to humbly ask if you would accept a corresponding patch to also make others benefit from those improvements?

With kind regards, Andreas.

funkyfuture commented 1 year ago

ciao, thanks for the feedback.

afaik poetry doesn't support PEP-621 and doesn't intend to do so. looking at the extension you use, it doesn't seem to be too much of an impact on the codebase. but i wonder how the dispatching logic would look like. would it be much effort to demonstrate that in a PR? i'd like the tool generally assume that metadata is provided as said PEP prescribes. but maybe i would find a concrete proposal simple enough to accept it.

in general i would harshly recommend to not use poetry at all. for applications it can be okay, (see this article why one shouldn't pin versions for libraries). in wetterdienst's (grundsätzlich och danke dafür) case you could think about using pip-freeze in conjunction with container image builds for reproducablity. but that's all not my turf.

whatever the outcome, i'm glad that your colleague could easily extend this tool for your needs. addendum: and i'm totally open to provide better hooks for less code duplication on your side.

amotl commented 1 year ago

Hi Frank,

thanks for your prompt and swift response.

In general i would recommend to not use Poetry at all.

After setuptools v64 gained support for --editable installs the other day, we may get rid of Poetry, and I also stopped using it on more recent projects of mine. However, currently, on Wetterdienst, it is still there, and I believe others are using it as well, so it can be chance to improve the scope of cff-from-621, even if I recognize you are not a fan at all ;].

Looking at the extension you use, it doesn't seem to be too much of an impact on the codebase.

Yeah, I think it looks doable without having too much negative implications.

I wonder how the dispatching logic would look like. Would it be much effort to demonstrate that in a PR?

I can give it a try, and then we can judge about the outcome. Thanks!

I'm totally open to provide better hooks for less code duplication on your side.

Sweet, thank you! Let's have a look at an initial patch, and then let's decide if it would be worth the efforts on your end?

Cheers, Andreas.

amotl commented 1 year ago

Thanks also for sharing the article Semantic Versioning Will Not Save You. Reading about Hauptversionserhöhungsangst! ^1 made my day ;].