delba / Permission

A unified API to ask for permissions on iOS
MIT License
2.9k stars 320 forks source link

Won't compile on Swift 4.2 #133

Closed johnharutyunyan closed 4 years ago

johnharutyunyan commented 5 years ago

Please can you make some changes?

evdeve commented 5 years ago

@johnharutyunyan There is descision for you: pod 'Permission', :git => 'https://github.com/evdeve/Permission'

johnharutyunyan commented 5 years ago

@evdeve , thank you!!!

hytaoist commented 5 years ago

@johnharutyunyan There is descision for you: pod 'Permission', :git => 'https://github.com/evdeve/Permission'

when i use it in a empty project, and pod install correctly, it occur a error call "Function with uninhabited return type 'PermissionType' is missing call to another never-returning function on all paths" in Permission.swift line: 136. public let type: PermissionType. ??? how can i fix? or any problem in my operation?

Ale111 commented 4 years ago

@johnharutyunyan There is descision for you: pod 'Permission', :git => 'https://github.com/evdeve/Permission'

when i use it in a empty project, and pod install correctly, it occur a error call "Function with uninhabited return type 'PermissionType' is missing call to another never-returning function on all paths" in Permission.swift line: 136. public let type: PermissionType. ??? how can i fix? or any problem in my operation?

Hi, have you found a solution to fix this issue? Thanks. Ale

delba commented 4 years ago

Hi @all, the project has been updated for Swift 5.1.

Also the error Function with uninhabited return type 'PermissionType' is missing call to another never-returning function on all paths has been fixed by adding an (internal) never case to PermissionType.