search

delba / Permission

A unified API to ask for permissions on iOS
MIT License
2.91k stars 323 forks source link

Add AddressBook Type separately from Contacts #24

Closed komitake closed 8 years ago

komitake commented 8 years ago

I add AddressBook Type separately from Contacts since there is the possibility that we still need to use it on iOS9 even it's deprecated..

delba commented 8 years ago

I don't understand. Why / when would we use Permission.AddressBook ?

Edit: Ok, I got it sorry. Could you please remove the mentions of AddressBook from Contacts.swift please?

komitake commented 8 years ago

I removed AddressBook from Contacts.swift, and added available attribute to PermissionType.Contacts Please check it!

delba commented 8 years ago

I'll check it tomorrow but it looks good to me 😃 Thanks!

delba commented 8 years ago

Thank you @komitake !!

🙇 🙇 🙇

JamesKuang commented 8 years ago

Just did a minor version pod update from an older version and can't compile because of the @available(iOS 9.0) due to this PR. I know I'm too late on this, but for future reference, I don't think a change like this should've been included in a minor version bump release.

delba commented 8 years ago

My bad @JamesKuang , that's definitely something I should get better at in the future. Thanks for the feedback :)