delba / Permission

A unified API to ask for permissions on iOS
MIT License
2.91k stars 323 forks source link

Pre-permission not working with .Bluetooth #36

Closed jakerockland closed 8 years ago

jakerockland commented 8 years ago

I'm having an issue using the pre-permission with the .Bluetooth Permission type. Does this have something to do with this line in Permission.swift case .Bluetooth: requestBluetooth(self.callback)?

Still a bit new to Swift so not 100% sure what is wrong here.

delba commented 8 years ago

What issue do you have?

jakerockland commented 8 years ago

The pre-permission seems to always fire, even if the permission has already been authorized previously, is this correct behaviour? Perhaps I'm just a bit confused about the expected behaviour.

delba commented 8 years ago

It definitely shouldn't fire indeed. I'm gonna look into it

jakerockland commented 8 years ago

That would be awesome, thanks so much for looking into it. If you have any issue re-creating the error I can try to send you some sample code of exactly how I am implementing the framework, but my implementation was pretty much just based on the sample documentation you gave but using the .Bluetooth permission.

AndrewSB commented 8 years ago

@delba: Im seeing this too.

jakerockland commented 8 years ago

@AndrewSB I believe I found a fix to this if you check out #70. 😄

delba commented 8 years ago

@AndrewSB did you had a change to try #70 ? I'm going to test it as well on my side :)

AndrewSB commented 8 years ago

I'll test #70 later today! On Thu, Oct 20, 2016 at 8:18 AM Damien notifications@github.com wrote:

@AndrewSB https://github.com/AndrewSB did you had a change to try #70 https://github.com/delba/Permission/pull/70 ? I'm going to test it as well on my side :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/delba/Permission/issues/36#issuecomment-255136942, or mute the thread https://github.com/notifications/unsubscribe-auth/ADo1dMvUB5BJSyVFakok2JKDHFlrSIVaks5q14YxgaJpZM4JDkMH .

jakerockland commented 8 years ago

This is now replaced with #74 for isolation from #69 @delba @AndrewSB

jakerockland commented 8 years ago

74 has now been replaced with #76 😛 @AndrewSB

delba commented 8 years ago

Fixed in https://github.com/delba/Permission/commit/f6b36cebcc72f2f99148b05cc813774d9a87972b